Closed nathantannar4 closed 6 years ago
Its a lot of lines but mostly documentation and views. Core logic in AttachmentManager and AutocompleteManager. AutocompleteManager was vetted by MessageViewController (Githawk)
@nathantannar4 This looks good to me, a few questions though:
After this pull request, what changes are present in InputAccessoryBarView
that are not in MessageInputBar
?
Have these two bugs been fixed in your library?
We should also add to the README that this project is not being used in MessageKit yet, it would be great if we could replace it in the next ~1.5 months though. This Summer for sure. Unit tests would give me more confidence of course. This is a 2.0 feature
This is pretty much the last of the changes. The merged PRs in your referenced issues are in MessageInputBar.
Sent with GitHawk
We should definitely have MessageKit using this repo for the v1.0 otherwise there could be name conflicts for people trying to use both
Sent with GitHawk
@nathantannar4 Good point on the naming conflicts 🤔 This is something I’ll think about this week
Sent with GitHawk
@nathantannar4 So this looks pretty safe to support MessageInputBar/Core
in MessageKit for version 2.0 🤔 There are some API breaking changes so I don't think I can get it in the first version.
Any API breaking changes I can revert
Sent with GitHawk
@nathantannar4 Please make these changes when you can so we can do https://github.com/MessageKit/MessageKit/issues/730
Forked the plugins I made in InputBarAccessoryView and make them subspecs for MessageInputBar