search

MesserLab / SLiM

SLiM is a genetically explicit forward simulation software package for population genetics and evolutionary biology. It is highly flexible, with a built-in scripting language, and has a cross-platform graphical modeling environment called SLiMgui.
https://messerlab.org/slim/
GNU General Public License v3.0
160 stars 30 forks source link

Use CMake to perform installation, and RPM macros #413

Closed bryce-carson closed 9 months ago

bryce-carson commented 9 months ago

Hi Ben,

This PR updates the RPM spec file for the 4.1 release, adopts recommended RPM macros rather than hard-coding things (though that did appear robust in the past), and makes CMake capable of installing SLiMgui, slim, and eidos with desktop integration (which simplifies the role of RPM and makes the spec file more maintainable).

It didn't cross my mind until now, but the following should work beautifully and provide desktop integration on Linux platforms when building from source and should also be integrated into the manual's installation instructions:

cmake -D BUILD_SLIMGUI=ON
make
make install # This line, on Linux, will now *also* install Desktop integration files.
bhaller commented 9 months ago

Looks good to me, thanks! I haven't looked at the manual changes you sent yet; I suppose the bit you mention above in your comment has been worked in with your edits.

bryce-carson commented 9 months ago

Looks good to me, thanks! I haven't looked at the manual changes you sent yet; I suppose the bit you mention above in your comment has been worked in with your edits.

Hi Ben,

It hasn't, actually. I sent my edits to you already, before I thought of it.

I will make the change now and re-send the edition, since that will probably be the easiest for both of us (it's easier for me than explaining where to make the edition, and easier for you too, I hope).