MesserLab / SLiM

SLiM is a genetically explicit forward simulation software package for population genetics and evolutionary biology. It is highly flexible, with a built-in scripting language, and has a cross-platform graphical modeling environment called SLiMgui.
https://messerlab.org/slim/
GNU General Public License v3.0
160 stars 30 forks source link

4.1 Memory Issue #422

Closed ans6160 closed 7 months ago

ans6160 commented 8 months ago

Hello,

I mentioned this issue on the google group page and was directed here. As stated in the original post, 4.1 uses an extensive amount of memory when running a simulation that worked in the previous version (4.0.1) causing the app to crash when just running the simulation in the gui or crash my computer when trying to run it through R. Attached below are the necessary files and code.

slim_v4.1_issue_scripts.zip

Thanks! Abigail

bhaller commented 8 months ago

Thanks! Sorry for the dead air, I've been quite sick for several days, and am only just starting to feel better. I will look into this as soon as I can. Thank you for the bug report.

bhaller commented 7 months ago

Hi @ans6160,

I've fixed this issue, I think, and the fix is pushed to GitHub. It was a fairly bad bug, so I will post about it on slim-discuss in a moment; you can see further discussion there. You can get the fix by building the GitHub head version of SLiM, or you can stay on SLiM 4.0.1. Thanks for the very helpful bug report!

bhaller commented 7 months ago

Discussion here: https://groups.google.com/g/slim-discuss/c/bJP5d1dx848/m/DRMA0vL3AAAJ

petrelharp commented 7 months ago

Damn, this looks subtle.

ans6160 commented 7 months ago

Thank you! For now I will stay on 4.0.1.

bhaller commented 7 months ago

Damn, this looks subtle.

An unintended side effect of a rearchitecture of MutationRun to support parallel SLiM. A bit subtle if one has not already lived through the whole soap opera up to this point, yes. :-> The fix is rather ugly, but I can't think of a better one offhand. Might be a nice thing to talk through at some point, actually, but I know you're swamped right now, and so am I...