MesserLab / SLiM

SLiM is a genetically explicit forward simulation software package for population genetics and evolutionary biology. It is highly flexible, with a built-in scripting language, and has a cross-platform graphical modeling environment called SLiMgui.
https://messerlab.org/slim/
GNU General Public License v3.0
160 stars 30 forks source link

conda caching does not seem to be working for macos-13 #454

Closed bhaller closed 1 month ago

bhaller commented 1 month ago

Hi @petrelharp. You can see that building on macos-13 is not working. GitHub recently deactivated/removed macos-11; it's time to get macos-13 working (which it never has). An example of the failure can be seen here:

https://github.com/MesserLab/SLiM/actions/runs/9931045744/job/27430479498

The problem is with conda; you can see the error:

/Users/runner/.profile: line 22: conda: command not found

(Just above that there is a "TODO", by you I think, that might also be relevant.) This error is mystifying to me, though, because earlier in the log are the steps for "Cache conda and dependencies" and "Install conda". The log says "Cache restored successfully", and it seems to think it succeeded. So why can't it find conda later on? And why does this problem only manifest on macos-13, not macos-12?

This kind of thing mystifies me. Since you put the conda caching stuff in, and perhaps understand it, can you please fix this problem? Thankyouthankyouthankyou.

bhaller commented 1 month ago

Hey, for some reason I can assign issues to you now! Woot!

bhaller commented 1 month ago

If it makes the design/maintenance of this conda stuff simpler, I wonder: is it really worth using this cache mechanism? A GitHub admin claimed, in a thread I was reading to try to orient myself on this problem, that installing conda takes ~20 seconds (miniconda, in particular, I guess; not sure whether that suffices for our purposes). That is not huge; maybe if the caching is giving us difficulties it isn't worth it? But I leave that up to you. :->

bhaller commented 1 month ago

This got fixed by @currocam in #457, closing.