search

MesserLab / SLiM

SLiM is a genetically explicit forward simulation software package for population genetics and evolutionary biology. It is highly flexible, with a built-in scripting language, and has a cross-platform graphical modeling environment called SLiMgui.
https://messerlab.org/slim/
GNU General Public License v3.0
160 stars 30 forks source link

Use make test in CI #455

Closed currocam closed 1 month ago

currocam commented 1 month ago

As we agreed yesterday, here's a minimal PR using make test in the CI. I have also modified the Cmake file to also run the Eidos test suite from the Eidos executable (to match previous CI).

bhaller commented 1 month ago

Perfect, thanks @currocam!

If you want another project (lol), as you can see the macos-13 CI is failing (and always has, when I have tried it before) because conda is not installed by GitHub Actions any more on macos CI builds, starting with macos-13 (see, e.g., https://github.com/actions/runner-images/issues/9262; you can find many discussions of this in Google, their decision to remove it broke a ton of builds). The weird thing is that our CI .yaml already has its own script to install conda, with a whole caching mechanism and such, so conda ought to be there even though GitHub Actions no longer installs it for us. But it isn't, apparently; I have no idea why, and debugging this kind of thing is very much not my forté. :-> If this sounds like something you can figure out, I'd appreciate the help! The issue is here: https://github.com/MesserLab/SLiM/issues/454. But if not, no worries. Thank you very much for your help with this make test issue!

currocam commented 1 month ago

I've done some work git GitHub Actions before, so I might give it a try!

Perfect, thanks @currocam!

If you want another project (lol), as you can see the macos-13 CI is failing (and always has, when I have tried it before) because conda is not installed by GitHub Actions any more on macos CI builds, starting with macos-13 (see, e.g., actions/runner-images#9262; you can find many discussions of this in Google, their decision to remove it broke a ton of builds). The weird thing is that our CI .yaml already has its own script to install conda, with a whole caching mechanism and such, so conda ought to be there even though GitHub Actions no longer installs it for us. But it isn't, apparently; I have no idea why, and debugging this kind of thing is very much not my forté. :-> If this sounds like something you can figure out, I'd appreciate the help! The issue is here: #454. But if not, no worries. Thank you very much for your help with this make test issue!