search

Mester / demo-day-vikings

The Unlicense
2 stars 1 forks source link

Ditch oauth #54

Closed tylerphillips55 closed 8 years ago

tylerphillips55 commented 8 years ago

I was incorrect. The only value in doing this is escaping api's oAuth requirement; it is still beneficial. Like the api, we are still limited to 1000 posts, procured through 10 requests.

anubhavcodes commented 8 years ago

This is good, and much easier to understand. What do you think @tylerphillips55 , do we still need the Post class?

This is good, but the search results still take a lot of time. We need to make changes to make sure that the json is only fetched if there are any new posts on the subreddit, but this will require lot of code changes and architecture change, lot of refactoring. Let's stick to this and close this.

bdauer commented 8 years ago

This is looking a lot cleaner to me. I think we can do away with the post class.

Once we have the db up and running, we could check each entry against the database, and if it's already in there stop fetching. I'm creating an issue for discussing the db.

anubhavcodes commented 8 years ago

Everyone checkout master and git fetch origin && git merge origin/master