Website design - Githubissues

MesterMan03 / Bedlessbot

This is an epic bot (by an epic person) that handles role applications and level system for Bedless Nation.

https://discord.gg/bedless-nation-691898152277508146

Apache License 2.0

2 stars 1 forks source link

Website design #16

Closed noClaps closed 1 week ago

noClaps commented 2 weeks ago

Pull Request Template

Description

Added styles for index and packs pages.

Fixes #8 Fixes #9

Type of Change

Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

noClaps commented 2 weeks ago

@jonahlikescookies If you'd like to work on some of these changes feel free to do so.

MesterMan03 commented 1 week ago

Ok so I've added the "Enable Notifications" button to the comment success modal, but make sure to check if it needs any styling.

MesterMan03 commented 1 week ago

[ ] Adding to the date value for comments being used, the individual comment layout could probably use a refresh. The avatar is too big, it leaves a bunch of space behind and it just doesn't look nice. Here is a little sketch of what I think it could look like.
[x] The close button in the modal shouldn't hide the text behind it. For the image I shrunk the page, but this will naturally occur with a long sentence.

jonahlikescookies commented 1 week ago

Due to the size of the section for comments, very little of people’s usernames are shown(only 2 characters in this case). If we go off of the initial sketch, then we should definitely increase the width available to use. However, that would make the grid layout not fit, as currently, it barely does. Any ideas on how to fix this?

MesterMan03 commented 1 week ago

Probably the best solution would be to move the date below the username. There should be enough space next to the avatar for both.

MesterMan03 commented 1 week ago

I've also tried my best to create a mobile layout. I'd say it's pretty usable, but it definitely needs some minor adjustments, the image inside the comment toggle button looks a bit off for example and the pure black background for the comments in mobile layout is not final, I just set a random color as a placeholder.

I'll mark the mobile layout as complete nonetheless, just keep this in mind.