search

MestreLion / git-tools

Assorted git tools, including git-restore-mtime
GNU General Public License v3.0
295 stars 74 forks source link

NameError: global name 'filterlist' is not defined #1

Closed rasa closed 11 years ago

rasa commented 11 years ago

When I run the latest version of git-restore-mtime-core, in a git repository checkout, I get the following error:

Traceback (most recent call last):
  File "/home/ross/bin/git-restore-mtime-core", line 114, in <module>
    parselog(args.merge)
  File "/home/ross/bin/git-restore-mtime-core", line 86, in parselog
    (['-m'] if merge else []) + filterlist,
NameError: global name 'filterlist' is not defined

What am I doing wrong?

Thanks!

MestreLion commented 11 years ago

Good eye! The -core version didn't have much testing, it was only created as a stripped-down version for a proof-of-concept. git-restore-mtime is the one meant for production use.

I've noticed you also provided the fix. Is it possible for you to rebase those 2 commits into a single one, and also add a "git-restore-mtime-core:" prefix to the commit message, so I can merge your fix into my repository? Thanks!