MestreLion / humblebundle

API for managing Humble Bundle games library
GNU General Public License v3.0
211 stars 38 forks source link

Fix empty string in use of keyring #17

Closed Sec42 closed 8 years ago

Sec42 commented 8 years ago

This change fixes saving/loading credentials for me. Otherwise I get 2016-08-24 19:56:24,918 CRITICAL File contains parsing errors: /home/sec/.local/share/python_keyring/keyring_pass.cfg

MestreLion commented 8 years ago

Thanks for the patch! Gave you full credit but ended up using a slightly changed commit, namely using appname as the string, which renders as 'humblebundle' instead of a hardcoded 'humble'.

Btw, this seems to be a new requirement on Python Keyring... what version are you using? Care to paste the output dpkg -l python-keyring? (if on Debian/Ubuntu, or the equivalent in your distro)

Sec42 commented 8 years ago

Thanks for fixing it.

As requested, this happend for me with: ii python-keyring 7.3-1ubuntu1 all store and access your passwords safely