MestreLion / humblebundle

API for managing Humble Bundle games library
GNU General Public License v3.0
209 stars 38 forks source link

Download option working in Python 3 #42

Closed chilinux closed 6 years ago

chilinux commented 6 years ago

I had not tested the download capability under Python 3 previously. It turned out this option needed some minor modifications. With this pull request, I have now gotten the download option working in Python 3.

When called with the trace module, it wasn't passing the argv correctly to the main() function. I made a minor tweak to work-around this.

I ran into an issue with iterating over binary reads that it would iterate forever since python v3 treats '' and b'' as two different things. The kept the script from proceeding past the download.

It also seems like Progressbar v2 has no currval but both the python v2 and v3 modules have "value" instead.

Let me know if there is anything you would like see modified in the pull request before merging.

MestreLion commented 6 years ago

Thanks!