search

MestreLion / roguepc

Port of original PC-DOS Epyx Rogue to modern platforms
27 stars 6 forks source link

Small fix in the monster table #23

Open memmaker opened 6 months ago

memmaker commented 6 months ago

IsGreed is supposed to be the flag

MestreLion commented 6 months ago

Wow, nicely spotted, thanks!

This being a gameplay change, even a bugfix one, would you mind enclosing it in a #ifdef ROGUE_BUGFIX block, keeping the original behavior in the #else clause?

This means ISGREED, being currently (well, in 1985) at m_carry, gives the Leprechaun a huge chance of carrying items. It seems UNIX Rogue 5.x, which supposedly this Epyx Rogue was based on, had both m_carry and m_flag set to 0! Maybe de-compiling v1.49 would also help.

In any case, simply swapping the values might not be the "proper" fix. Would have to check other versions from the same era to discover the what the intended values were supposed to be.

MestreLion commented 6 months ago

On a side-note to myself, I'll have to add this new ROGUE_BUGFIX to documentation, and retroactively apply it to #22