search

MetOffice / CATNIP

Climate Analysis Tool: Now In Python
Other
5 stars 2 forks source link

Feature action #136

Closed zmaalick closed 3 years ago

nhsavage commented 4 years ago
  1. why has the test_analysis.py been updated? Are the results different in the Actions Environment? If so do the local tests now fail?
  2. do the arguments like --max-complexity=10 --max-line-length=127 override the .flake8 file? And why are there two calls to flake8?
  3. I have no experience with this, so I wonder if we should request a reviewer on Yammer?
zmaalick commented 4 years ago
  1. why has the test_analysis.py been updated? Are the results different in the Actions Environment? If so do the local tests now fail?
  2. do the arguments like --max-complexity=10 --max-line-length=127 override the .flake8 file? And why are there two calls to flake8?
  3. I have no experience with this, so I wonder if we should request a reviewer on Yammer?

  1. test_analysis was failing because of significant digit. In couple of test cases we restrict the significant digits to three. We need to fix it to three in this function too.

  2. Consider flake8 test just a running example. We are yet to merge the flake8 file. Once that branch is merged, I will update it according to codes.

  3. We can ask somebody from Yammer.

nhsavage commented 4 years ago

can you please open an issue for the significant digits issue in this test ? then see if you can get someone with more experience to have a quick look. If they are happy then I approve this

zmaalick commented 4 years ago

can you please open an issue for the significant digits issue in this test ? then see if you can get someone with more experience to have a quick look. If they are happy then I approve this

Sure