Feature test common timeperiod

MetOffice / CATNIP

Climate Analysis Tool: Now In Python

Other

5 stars 2 forks source link

Feature test common timeperiod #46

Closed nhsavage closed 4 years ago

nhsavage commented 4 years ago

Hi Zubair,

issuing a PR for this as I'd like to talk to you about it when I come back from leave. I now realise that my negative tests are not actually what you intended us to implement i.e. I haven't added any additional raises in the function being tested (the tests suceed but I'm not sure how useful they are). I'd like to discuss this with you,

Closes #42

nhsavage commented 4 years ago

incorrectly named branch will be replaced with correctly named one