search

MetOffice / CATNIP

Climate Analysis Tool: Now In Python
Other
5 stars 2 forks source link

Testing: git hooks #8

Closed zmaalick closed 3 years ago

zmaalick commented 4 years ago

Make use of git hooks

nhsavage commented 4 years ago

use git hooks to:

  1. run tests
  2. update docs
nhsavage commented 3 years ago

I think that we have implemented this using Github actions and this should now be closed. Do you agree @zmaalick

zmaalick commented 3 years ago

Git hooks are different. They lie in local repo.

You can see under ~/CATNIP/.git/hooks

the concept is similar to Actions but at the time of commit or push ..

so these are mainly pre-commit or pre-push checks (not necessarily include all unit tests).

nhsavage commented 3 years ago

I understand the difference. What I am asking is, are there still things we want to implement using git hooks?

zmaalick commented 3 years ago

Not sure, I do not have any specific test in mind to add here .

From: Nick Savage notifications@github.com Sent: 21 September 2020 14:01 To: MetOffice/CATNIP CATNIP@noreply.github.com Cc: Maalick, Zubair zubair.maalick@metoffice.gov.uk; Mention mention@noreply.github.com Subject: Re: [MetOffice/CATNIP] Testing: git hooks (#8)

I understand the difference. What I am asking is, are there still things we want to implement using git hooks?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/MetOffice/CATNIP/issues/8#issuecomment-696097980, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN2CPNARXOP2O5F5GPLLINDSG5E7ZANCNFSM4K5M6VEQ.

nhsavage commented 3 years ago

I will close this - if we find a use case for hooks. we should open a new issue with the details