search

MetOffice / CSET

Toolkit for evaluation and investigation of numerical models for weather and climate applications.
https://metoffice.github.io/CSET/
Apache License 2.0
10 stars 4 forks source link

Fix docstring typo in xycoord identifier in _utils #664

Closed jwarner8 closed 4 months ago

jwarner8 commented 4 months ago

Quick fix to docstring specifying the expected return (wrong way round). No change in functionality/executable code.

github-actions[bot] commented 4 months ago

Coverage

jfrost-mo commented 4 months ago

Looks good. Only thing that comes to mind is whether we should actually change the implementation, and fix the users, as it seems to me that x then y is a more natural ordering.

jwarner8 commented 4 months ago

Looks good. Only thing that comes to mind is whether we should actually change the implementation, and fix the users, as it seems to me that x then y is a more natural ordering.

I pondered on this quite a bit. X, then Y, sounds more natural. But if you print most cubes, it'll usually specify latitude, before longitude axis. Etc (time,latitude,longitude), or (time,pressure,latitude,longitude),

jwarner8 commented 4 months ago

There's never anything simple in weather science. One suggestion I do have then, is to rename this function (and all uses of it) to get_cube_yxcoord_name, so we are at least consistent.

Don't we know!! OK - have changed references, think only plot.py actively uses it in trunk. Will merge into crosssection and age of air branches so I can pickup this change.

jfrost-mo commented 4 months ago

Actually, I'll look at the test failures first.

jwarner8 commented 4 months ago

Hold fire - found a bug in regrid which expects the coords in the other order. Will fix this now