MetOffice / CSET

Toolkit for evaluation and investigation of numerical models for weather and climate applications.
https://metoffice.github.io/CSET/
Apache License 2.0
8 stars 1 forks source link

Clarify documentation around when a specific kind of review is required #671

Open jfrost-mo opened 1 month ago

jfrost-mo commented 1 month ago

What problem does your feature request solve?

We should clarify the expectation for different levels of review, depending on the type of change. Currently this is lightly mentioned in the git documentation however it should be more thoroughly covered.

This will make it clearer what level of review people should ask for when making a PR, and better set expectations.

Describe the solution you'd like

The obvious place for this is the Code Review documentation, which currently does not mention this at all.

The note in the Pull Requests section should also be removed now.

We might also want to consider additional tooling to help with requiring multiple approving reviews.