MetOffice / CSET

Toolkit for evaluation and investigation of numerical models for weather and climate applications.
https://metoffice.github.io/CSET/
Apache License 2.0
8 stars 1 forks source link

UM spatial plot on model levels #699

Open Sylviabohnenstengel opened 6 days ago

Sylviabohnenstengel commented 6 days ago

Fixes #https://github.com/MetOffice/CSET/issues/698

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

github-actions[bot] commented 6 days ago

Coverage

Sylviabohnenstengel commented 6 days ago

@jfrost-mo I think I need a2nd pair of eyes. CLI recipe works, but running in cylc gives me an error message that the recipe does not exist.

Pre-processing data into intermediate form. 2024-06-26 15:04:00,926 INFO recipe file: generic_mlevel_spatial_plot_sequence.yaml 2024-06-26 15:04:00,927 INFO input_dir: None 2024-06-26 15:04:01,112 DEBUG Getting recipe: /workflow-conda-env/lib/python3.12/site-packages/CSET/recipes/generic_mlevel_spatial_plot_sequence.yaml 2024-06-26 15:04:01,112 ERROR Recipe generic_mlevel_spatial_plot_sequence.yaml does not exist. 2024-06-26 15:04:01,154 ERROR cset bake exited non-zero while processing. [FAIL] app_env_wrapper run-cset-recipe.py # return-code=1 2024-06-26T15:04:02Z CRITICAL - failed/ERR

Sylviabohnenstengel commented 6 days ago

@jfrost-mo I moved the plotting of the spatial fields on model levels int the parallel step and not into teh collate step and it now works, however I still think the plot spatial operator should be in the collate step with time as sequence_coordinate. In the parallel step the cubes are all in individual processes split by modellevel as well as time, so having the plot operator in the parralel step does not seem to make sense?

Sylviabohnenstengel commented 5 days ago

now working with plotting step in the collate part of the recipe

jfrost-mo commented 1 day ago

Branch rebased.