MetOffice / CSET

Toolkit for evaluation and investigation of numerical models for weather and climate applications.
https://metoffice.github.io/CSET/
Apache License 2.0
10 stars 4 forks source link

Enhance level filter operator to return all vertical levels #728

Closed jwarner8 closed 2 months ago

jwarner8 commented 3 months ago

Fixes #726

Enables us to filter by cubes with no vertical coordinate, cubeslists that have variables with multiple vertical coordinates.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

github-actions[bot] commented 3 months ago

Coverage

jwarner8 commented 3 months ago

This has been tested with UM data, ensemble data (UM), LFRic and some ML data. Some ML data is not working in the collate step, but I think this is due to metadata in the cubes (forecast_period) switching from hours to day, possibly not netcdf compliant. Also made some changes to transect based on these changes

jfrost-mo commented 2 months ago

Tests are just failing due to the DT Center website being down. I've opened a PR to remove that as a dependency in #749, which you could review if you fancy.