search

MetOffice / PyPRECIS

PyPRECIS is the python based training environment for Met Office PRECIS training courses.
BSD 3-Clause "New" or "Revised" License
20 stars 2 forks source link

Make a version of the notebooks for the AFR-22 domain #136

Closed nhsavage closed 2 years ago

nhsavage commented 2 years ago

These are a new set of notebooks, derived from the EAS-22 ones. Some fixes to the notebooks will need to be pushed back to the EAS-22 ones. I will open a separate ticket for these issues.

rosannaamato commented 2 years ago

Branch reverted to Nick's last commit (cc22230) as I have removed my commits that should have been made in a separate branch. Apologies, tidy again.

nhsavage commented 2 years ago

General comment I think one of the main possible stumbling blocks is the underlying assumption about which directory the user is in, I would be tempted at least at the start of every worksheet to add in a pwd or similar so users can check they are in the right directory.

I agree that this is a stumbling block. However I think it has to be addressed on a different issue. The challenge with it is that the path to use will be platform dependent - so some sort of include file with the platform specific needs to be set up. This would also include potentially scripts fetching from S3 buckets or precisrcm and doing the linking.

nhsavage commented 2 years ago

General comment I think one of the main possible stumbling blocks is the underlying assumption about which directory the user is in, I would be tempted at least at the start of every worksheet to add in a pwd or similar so users can check they are in the right directory.

I agree that this is a stumbling block. However I think it has to be addressed on a different issue. The challenge with it is that the path to use will be platform dependent - so some sort of include file with the platform specific needs to be set up. This would also include potentially scripts fetching from S3 buckets or precisrcm and doing the linking.

On reflection, I will make this work for the existing VDI set up and I have opened #145 to deal with multiple sets of options for download of data

nhsavage commented 2 years ago

Closes #124

nhsavage commented 2 years ago

I have now updated to account for the comments apart from the last one "in the first code block of 1.2 I would recommend explicitly cding into the correct directory (to prevent confusion, even though they should already be in it.)" - I want this to be covered in a follow on ticket