search

MetOffice / monio

Met Office NetCDF I/O (MONIO) written in C++ for file I/O in JEDI-based DA (JADA).
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Bugfix/fieldset write #14

Closed phlndrwd closed 1 year ago

phlndrwd commented 1 year ago

Fix of problem with Monio::writeFieldSet which didn't preserve dimensions across fields during memory-efficient write. It accidentally arrived at something that would have probably worked, but would likely have caused problems when used generally.

Current test outputs: http://fcm1/cylc-review/taskjobs/punderwo/?suite=monio_fieldset_write1

See below for plots of data: pot_temp skin_temp

NB: Please ignore changes to Monio:writeIncrements. It was easier to include the changes here than it was to backtrack and isolate the changes for this bugfix.

phlndrwd commented 1 year ago

Well found, thanks. I've ignored the Monio::writeIncrements changes for now as tests pass

Thanks Josh. They do, as they did before, but this probably highlights how the tests need to be added to.