Feature/increment read

[phlndrwd]

This PR introduces the required code changes to MONIO for increment reading from LFRic-Lite.

It is dependent on PR [https://github.com/JCSDA-internal/lfric-lite-jedi/pull/344] in LFRic-Lite

Test outputs are here: http://fcm1/cylc-review/taskjobs/punderwo/?suite=monio_increment_read_01

[phlndrwd]

s field interface simply skips the 0th level when writing to the lfric fields (and subsequently writing to XIOS fields & to file), so when writing this bottom level is 0 (as the io fields are zeroed) rather than being duplicated from the level just above the surface. It would be easy enough to change to have the same behaviour.

I'm not sure which is best, especially for the increment case. (Tagging @ss421)

We should probably chat about this. Maybe an agenda item for the next meeting? I was concerned that the current solution may be overly specialised for LFRic-Lite.

[phlndrwd]

Thanks @mo-joshuacolclough! Ever efficient and eagle-eyed!

[mo-joshuacolclough]

Thank _you for the change!

[ss421]

Looks good, thanks. The logic for copying the surface level looks correct to me, although it differs slightly from what the lfric/atlas field interfaces do in lfric-jedi (for copying to/from the model).

At present the lfric/atlas field interface simply skips the 0th level when writing to the lfric fields (and subsequently writing to XIOS fields & to file), so when writing this bottom level is 0 (as the io fields are zeroed) rather than being duplicated from the level just above the surface. It would be easy enough to change to have the same behaviour.

I'm not sure which is best, especially for the increment case. (Tagging @ss421)

Thanks Josh. Yes we can make JEDI-LFRIC do the same thing.