search

MetOffice / monio

Met Office NetCDF I/O (MONIO) written in C++ for file I/O in JEDI-based DA (JADA).
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

update ci workflow #35

Closed yaswant closed 3 months ago

yaswant commented 9 months ago

Update CI workflows

Example build group annotation

build-group=JCSDA-internal/oops#2714

yaswant commented 9 months ago

I anticipate the manual workflow to work okay with manual trigger, but cant be tested until merged in develop. I may need to open a follow-up PR in case the manual workflow proves problematic.

yaswant commented 4 months ago

@phlndrwd @odlomax - can you review this PR please?

yaswant commented 3 months ago

@phlndrwd note that monio tests still depend on legacy lfric-lite test data. Worth moving them to monio's own test suite or use cases from lfric-jedi instead?

phlndrwd commented 3 months ago

@phlndrwd note that monio tests still depend on legacy lfric-lite test data. Worth moving them to monio's own test suite or use cases from lfric-jedi instead?

Thanks @yaswant. I guess this would be a trade-off between when the legacy data is due to disappear and when XIOS is expected to take-over from MONIO. If there is significant overlap then I don't think it would be worth making any significant changes here. Though I'm not in a position to answer this alone so it might be a conversation to be had with @odlomax, @matthewrmshin, & @mo-joshuacolclough, et al.