search

MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

cx and varobs for aircraft #154

Closed adammartins closed 1 year ago

adammartins commented 1 year ago

Add aircraft cx and varobs namelist for use with sith.

ctgh commented 1 year ago

Thanks for adding these. They look good to me but could you please add some unit tests to check they behave as expected?

These are some instructions I put on Lee's surface PR for the CX generation. You can do similar things for the varobs.

(1) Edit opsinputs/test/generate_unittest_netcdfs.py. Near the bottom, there are calls to the routine output_full_cx_to_netcdf for different data types. You can add an entry for Aircraft there and tailor it to use the correct CX columns.

(2) Create a new file called opsinputs/test/testinput/cxwriter_globalnamelist_aircraft.yaml (probably easiest to copy from an existing one). Again, modify it to test the correct CX columns.

mikecooke77 commented 1 year ago

@adammartins the code changes look good. Could you update to develop and resolve conflicts and then I'm happy to approve and merge.