search

MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

update licence #167

Closed yaswant closed 1 year ago

yaswant commented 1 year ago

Add BSD3 licence.

matthewrmshin commented 1 year ago

Do we still need the old licence file (COPYRIGHT.txt)?

yaswant commented 1 year ago

Do we still need the old licence file (COPYRIGHT.txt)?

matthewrmshin commented 1 year ago
  • Also, we were asked to add Crown copyright statement in all necessary files. I believe some of the Fortran utils were copied from elsewhere - those codes should not have the crown copyrights. Shall we leave this part as they are?

Yes, I believe they should be left as-is. If they have different licences, we should include those in separate licence files. As an example, in FCM's source tree, we have a doc linked from its README to acknowledge work that are simply bundled into the project. https://github.com/metomi/fcm#acknowledgement-for-non-fcm-work

yaswant commented 1 year ago

Most codes contain reference to COPYRIGHT.txt file in the following forms

a) 

!-------------------------------------------------------------------------------
! (C) Crown copyright Met Office. All rights reserved.
!     Refer to COPYRIGHT.txt of this distribution for details.
!-------------------------------------------------------------------------------

b)

! *****************************COPYRIGHT*******************************
! (c) CROWN COPYRIGHT, Met Office, All Rights Reserved.
! Please refer to Copyright file in top level GCOM directory
!                 for further details
! *****************************COPYRIGHT*******************************
yaswant commented 1 year ago

@matthewrmshin Getting my head around the legal bit. Perhaps the copyright notice is a requirement for bsd3. I see https://github.com/metomi/fab have both. Perhaps its better to keep the Copyright file - what do you think?

yaswant commented 1 year ago

@mikecooke77 I've attempted to tidy the varfields table, but that definitely needs updating in a separate PR.

matthewrmshin commented 1 year ago

@matthewrmshin Getting my head around the legal bit. Perhaps the copyright notice is a requirement for bsd3. I see https://github.com/metomi/fab have both. Perhaps its better to keep the Copyright file - what do you think?

I don't think so. We just need a single COPYING, LICENSE or LICENSE.md file. COPYRIGHT.txt was an artifact of our old Met Office proprietary licence. GitHub Help has a few pages about licensing, e.g.: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository

yaswant commented 1 year ago

@matthewrmshin Getting my head around the legal bit. Perhaps the copyright notice is a requirement for bsd3. I see https://github.com/metomi/fab have both. Perhaps its better to keep the Copyright file - what do you think?

I don't think so. We just need a single COPYING, LICENSE or LICENSE.md file. COPYRIGHT.txt was an artifact of our old Met Office proprietary licence. GitHub Help has a few pages about licensing, e.g.: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository

Done!

yaswant commented 1 year ago

I thought about that, but then realised the date can be left as date of first publication in order to avoid any ownership conflicts in the future (again different countries have different set of rules to make things more complicated).

We can remove the year stamp altogether though. Would you prefer this instead?

matthewrmshin commented 1 year ago

Let's leave the year stamp for now.

mo-glenngreed commented 1 year ago

Having browsed the code and the changes, I am happy with the licence and the headers in the files.

yaswant commented 1 year ago

@mikecooke77 I think you have pushed another PR very recently for this conflict? Can you comment?

Ignore that, I see now you have done a merge develop.