search

MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Changes for ufo-2848. #172

Closed DJDavies2 closed 1 year ago

DJDavies2 commented 1 year ago

This is to be merged alongside https://github.com/JCSDA-internal/ufo/pull/2848 and https://github.com/JCSDA-internal/oops/pull/2212. These are changes suggested by @wsmigaj. Test output is here: http://fcm1/cylc-review/taskjobs/frwd?&suite=oops-2212.

Depends on

DJDavies2 commented 1 year ago

I don't know what that failure means?

yaswant commented 1 year ago

I don't know what that failure means?

This is an extra level of protection for opsinputs specific - it indicates that you have not set the "ready to merge" label.

image

DJDavies2 commented 1 year ago

Okay I have set it.

yaswant commented 1 year ago

I've updated description and removed "ready to merge" label as the dependent PRs are still open. Please update the label when appropriate.

⚠️ We need to retest opsinputs should there be further changes to dependent branches of ufo and oops.

mikecooke77 commented 1 year ago

@DJDavies2 I see the associated PRs are now in. If you are happy for this to be merged please remove the do not merge flag.

DJDavies2 commented 1 year ago

Done.