MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Unrotate 10m winds #190

Closed james-cotton closed 11 months ago

james-cotton commented 11 months ago

In the UKV, we need to unrotate the wind components u10 and v10 before writing out the CX columns, as was done for u and v in https://github.com/MetOffice/opsinputs/pull/133 .

Fixes #140

n.b. Changes are easier to view if whitespace changes are hidden.

mikecooke77 commented 11 months ago

@james-cotton if this is ready please add the ready to merge flag and I'll merge

mikecooke77 commented 11 months ago

Also is it worth running any of the kgo's or not?

james-cotton commented 11 months ago

@mikecooke77 I have just run the ukv KGO with this build and the sonde output is unchanged http://fcm1/cylc-review/taskjobs/frjd/?suite=sith_winds_kgo_ukv

I have also verified the Scatwind output is unrotated as expected.

james-cotton commented 11 months ago

Are you ok to merge this? @mikecooke77

Thanks