search

MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Update yaml files with the new syntax for where variable is_defined / is_not_defined #194

Closed james-cotton closed 9 months ago

james-cotton commented 9 months ago

Description

Refactors yamls in processWhere for is_defined and is_not_defined

Issue(s) addressed

Resolves #193

Impact

Requires changes in yamls that use filters with where statement: is_defined: -> changed to value: is_valid is_not_defined: -> changed to value: is_not_valid

ctgh commented 9 months ago

I'm happy with this change. Should we run the kgo testing with all repos updated?

Do you mean for sith, or all of the mo-bundle unit tests?

mikecooke77 commented 9 months ago

I'm happy with this change. Should we run the kgo testing with all repos updated?

Do you mean for sith, or all of the mo-bundle unit tests?

Probably kgo and mo-bundle.

ctgh commented 9 months ago

I'm happy with this change. Should we run the kgo testing with all repos updated?

Do you mean for sith, or all of the mo-bundle unit tests?

Probably kgo and mo-bundle.

Sure, I will update my build with this branch and run all of the unit tests. I already ran the KGO tests in the sith PR, but I can do that again with the updated build for completeness.

ctgh commented 9 months ago

Full ctest output is here: http://fcm1/cylc-review/taskjobs/chthomas/?suite=refactor_where_params Everything looks good to me.