MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Changes relating to the addition of `Variable` in OOPS JCSDA-internal/oops/pull/2646 #209

Closed mo-joshuacolclough closed 3 months ago

mo-joshuacolclough commented 3 months ago

Description

oops::Variables is used within opsinputs. Usage of oops::Variables is changing in JCSDA-internal/oops/pull/2646.

I've tested with ops-um-jedi feature/use_variable and it resulted in some segmentation faults within opsinputs_cxwriter_post_f90. Here, it passes in an ioda::ObsDataVector flags object as a c_ptr, which then later is cast into an oops_variables type.

A change similar to https://github.com/JCSDA-internal/ioda/pull/1283/files may be required.