search

MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Changes required for addition of `oops::Variable`. Targeted merge: 11/06/24 #210

Closed mo-joshuacolclough closed 3 months ago

mo-joshuacolclough commented 3 months ago

Description.

For https://github.com/JCSDA-internal/oops/pull/2646. Fixes a segfault with the latest OOPS update. Changes oops_variables -> obs_variables such as is seen in the IODA change: https://github.com/JCSDA-internal/ioda/pull/1283/files.

Requires testing with all other feature/use_variable branches.

Issue

Resolves #209

Dependencies

Targeted merge date: 11/06/24.

Impact

Fixes usage of opsinputs downstream, with ops-um-jedi and lfric-lite-jedi atms_hofx tests.

mo-joshuacolclough commented 3 months ago

Thanks all :)

twsearle commented 3 months ago

@mikecooke77 I think deleting this branch has caused the UKMO OOPS CI to fail. I am restoring it to try and get them a green tick. Something for us to consider now we have build-groups working. https://github.com/JCSDA-internal/oops/actions/runs/9453134878/job/26037844053