search

MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Adding windspeed varobs test and oceanwinds var_cx test #216

Closed ghalloran closed 2 months ago

ghalloran commented 2 months ago

For processing Oceanwinds observations (ocean surface windspeed observations from eg.GNSS-reflectometry) we need to add var_cx capability and windspeed to the varobs.

ghalloran commented 2 months ago

Thanks for adding this - everything looks good. Do you also need to add a namelist for the varobs writer (i.e. etc/global/varobs/Oceanwinds.nl)?

Good question - I don't know! This doesn't include a test for an oceanwinds.varobs file itself, just adds the capability to output the surface windspeed itself, so I don't think it needs a namelist. I was just following the instructions on the opsinputs home page for the varobs part, and then for the cx part the instructions didn't help, so followed what has been done before for other obtypes.

ctgh commented 2 months ago

Thanks for explaining. Eventually you will need a varobs namelist in order to send output from JOPA to VAR. However I am happy to wait for a new PR to do that if you prefer. Sorry the instructions are out of date - copying what has been done previously is usually the best option.

james-cotton commented 2 months ago

If you don't supply a varobs namelist it will just use the code defaults, e.g. https://github.com/MetOffice/opsinputs/blob/develop/deps/ops/stubs/OpsMod_Varobs/Ops_GetDefaultVarfields.inc#L214 In this case we are only ever outputting a single varfield so the namelist isn't necessary.

ctgh commented 2 months ago

If you don't supply a varobs namelist it will just use the code defaults, e.g. https://github.com/MetOffice/opsinputs/blob/develop/deps/ops/stubs/OpsMod_Varobs/Ops_GetDefaultVarfields.inc#L214 In this case we are only ever outputting a single varfield so the namelist isn't necessary.

OK, thanks. Part of me would suggest adding one anyway, just to be explicit. However that could be done later if need be. Given that, I will approve.