search

MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

General Mode in post filters now as per yaml #218

Closed mikecooke77 closed 1 month ago

mikecooke77 commented 1 month ago

This PR fixes #217

In order to see how this affects the value of GeneralMode in the post filters there is a ctest in this branch. There is no need to commit this ctest as it is not actually testing anything just adding a couple of print statements which need manually checking.

https://github.com/MetOffice/opsinputs/tree/feature/separateGenMode_withctest

mikecooke77 commented 1 month ago

Thanks for catching this. I assume your extra ctest works as expected?

Yes I tested it initially and it picked up the final filter (cx) number and used this for both. I think this is because the code is compiled together and there is only one version of the Gen code and the flag is passed around by modules. With this change the first filter (varobs) had a different value to the second filter (cx).