MetOffice / opsinputs

JEDI library generating VarObs and Cx files
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Update to work with changes to UFO filters #225

Closed mikecooke77 closed 3 weeks ago

mikecooke77 commented 1 month ago

Introduction

This PR includes changes needed for some work in oops and ufo to move the filter factory to ufo.

There are also associated changes needed in orca-jedi and nemo-feedback which @ctgh has been working on.

Dependencies

build-group=https://github.com/JCSDA-internal/oops/pull/2760 build-group=https://github.com/JCSDA-internal/ufo/pull/3475 build-group=https://github.com/MetOffice/nemo-feedback/pull/72 build-group=https://github.com/MetOffice/orca-jedi/pull/121 build-group=https://github.com/MetOffice/jjdocs/pull/224

matthewrmshin commented 1 month ago

As discussed in Teams, I'm seeing some failures in sith/malak kgo runs using a build based on this PR and friends. Not sure if related or not.

log/job/20210701T1200Z/ukv_jopa_process_background_seviriclr/03/job.out sith-oj121-kgo_ukv~frsn: Cylc Review @ els032 - file view

log/job/20210701T1200Z/glu_jopa_process_background_airs/02/job.out malak-oj121-kgo_glu_jopa_jada~frsn: Cylc Review @ els032 - file view

log/job/20210701T1200Z/glu_jopa_process_background_airs/01/job.out malak-oj121-kgo_glu_jopa_var~frsn: Cylc Review @ els032 - file view

mikecooke77 commented 1 month ago

This is to do with validation of yamls and old settings which are now failing in the constructor. I don't understand why they were not failing before. @ctgh has kindly agreed to look into this next week. Sorry I hadn't done malak or sith testing.