MetOffice / qgis-plugin-edr

GNU General Public License v3.0
3 stars 1 forks source link

Add support for cube query #2

Closed m-burgoyne closed 4 months ago

JanCaha commented 4 months ago

@m-burgoyne This looks good, but I am not very comfortable with removing the CRS check in edr_plugin/coveragejson/utils.py. The check was introduced to handle some specific situations where the CRS imported was not a valid one and it could cause an issue.

We can discucuss if we want to use WKT or authid to identify the valid CRS, but the fallback mechanism to some CRS should stay there.

m-burgoyne commented 4 months ago

@JanCaha I have updated the code to include the CRS validity test, I have left the value as WKT as not all CRS will have an authid