search

MetPX / sarrac

C implementation of (a subset of) Sarracenia (large scale file transfer utility)
GNU General Public License v2.0
4 stars 1 forks source link

Issue141 2nd try #144

Closed petersilva closed 8 months ago

petersilva commented 9 months ago

close #141

Had to change global variables into pieces of context passed to library routines... a lot of changes, but that's all it did.

petersilva commented 9 months ago

I need to test a little more... but this might do it.

petersilva commented 9 months ago

Added some patches, and it looks like it does the right thing now. I asked the client to test. not sure if we should merge now or wait for client test result.

petersilva commented 8 months ago

As noted by @reidsunderland we still have some multi-threading vulnerabilities... perhaps best to address. will review.

petersilva commented 8 months ago

The multithreading stuff is quite big... in volume... it basically means getting rid of all variables declared static as there is always a race condition when called by multiple threads. I think it's better to have a separate branch for that (maybe more than one.) and merge this stuff (already >600 loc.) as is for now. It likely solves the user's problem as-is.