petersilva
commented
6 months ago symptom:
- given that DMS publishes messages with an incorrect size, the download downloads it three times, the first two times rejecting it as being the wrong size, and only on the third time does it check whether we accept incomplete/wrong sized downloads, so on the third try it succeeds.
Fix should be to accept any number of bytes immediately.
If you see ${0} in any configurations, and lots of DMS related ones do, then make sure that the: Sundew_compat_regex_first_match_is_zero True is in the config somewhere (See #839)
symptom: you see directories being named things like http or having slashes in the name. this is because python regex field 0 is the entire expression, whereas in sr v2 it meant the first match... so some pattern matches will put the entire URL in where it is supposed to be a single matched word.
remove nodupe_basis name where you see it when processing DMS messages, the default setting (path) works. ( See #1020 for more details)
symptom: nothing, or very little gets published because filename coming out of DMS are very far from unique.
remove subtopic msc-dms-dev.# (or equivalent based on DMS instance)
symptom: nothing gets matched, no downloading occurs. (this subtopic is absent from sr3 winnow outputs.)
Addressing issues discovered when downloading messages from DMS. The messages are a little different, and it tickles the sr3 code in certain ways that need to be addressed.