search

MetPX / sarracenia

https://MetPX.github.io/sarracenia
GNU General Public License v2.0
44 stars 22 forks source link

AM Miscellaneous fixes to mimic Sundew behaviour #980

Open andreleblanc11 opened 6 months ago

andreleblanc11 commented 6 months ago

Place holder for all small fixes made to flowcb/gather/am.py or bulletin.py. These were mostly all picked up by my auditing script, comparing with the old NCP nodes.

Fixes made so far in PRs

Reject float types for Julian day value in getTime : https://github.com/MetPX/sarracenia/pull/979 Add missing tokIsYear method from Sundew. Prevents some erronous bulletins not being filtered. : https://github.com/MetPX/sarracenia/pull/973 Add fix to handle improperly parsed station names from getStation : https://github.com/MetPX/sarracenia/pull/963 Properly handle trailing spaces at end of bulletin headers : https://github.com/MetPX/sarracenia/pull/956 Move AM renamer to gather. Allows us to properly use sundew variable expansions. : https://github.com/MetPX/sarracenia/pull/952 Lots of AM corrections (Renamer + AHL corrections in gather) : https://github.com/MetPX/sarracenia/pull/946

andreleblanc11 commented 5 months ago

With https://github.com/MetPX/sarracenia/issues/997 's fix that got pushed last week, I'm hoping that those were the final changes to AM before NCP move.

There hasn't been any Sundew compatible bugs found for about two weeks now.

andreleblanc11 commented 4 months ago

Found another bug. A BBB entry in the header was wrong and sr3 didn't filter it out like Sundew.

Sundew has a method that does this and more to verify the header. This should be likely added to sr3 -> https://github.com/MetPX/Sundew/blob/main/lib/bulletin.py#L601-L671

Not urgent. The sundew receiver downstream was able to filter the problem out so clients won't notice.

petersilva commented 4 months ago

BBB is OK, and should make it through... it depends on which header... I would only filter out invalid revision codes "AMENDMENT" is clearly wrong, but AMD, AAA, BBB, COR, are all OK.

UPDATE: nvmd... I understand you were referring to the header in general now, my bad.

andreleblanc11 commented 4 months ago

Need a patch for https://github.com/MetPX/Sundew/issues/20

andreleblanc11 commented 3 months ago

Take note of https://github.com/MetPX/sr_insects/pull/43#issue-2333937950

andreleblanc11 commented 1 month ago

There hasn't been any bugs found in the last couple of months. A good sign.