search

MetPX / sr_insects

test cases for sarracenia python and c implementations.
GNU General Public License v2.0
0 stars 0 forks source link

Add convert to flow tests. #10

Closed petersilva closed 1 year ago

petersilva commented 2 years ago

With the new convert function https://github.com/MetPX/sarracenia/issues/438 the flow tests coverage should be expanded to include applying v2 configs, and then converting them.

petersilva commented 2 years ago

branch issue10 built, doesn´t work yet.

cleaaum commented 2 years ago

it does work now!! Getting 30/30 on flow tests using the issue10 branch and the v03_wip_issue438_v03 branch in Sarracenia (pending PR). I also allowed .inc files to through the converter since the converter now takes care of that as well.

The fix was to build a deb package in order for my changes in sr3c to be reflected in the flow tests. I had added all the v3 options in the sr_config.c file and v3 configs were not working until the new build.

petersilva commented 1 year ago

working for me also... 1ee986d5ea8f3525e8b2f4aff0fedf425be57cda wasn't until this week. yay!