search

MetPX / sr_insects

test cases for sarracenia python and c implementations.
GNU General Public License v2.0
0 stars 0 forks source link

Add no_mirror test to test cases. #27

Closed petersilva closed 10 months ago

petersilva commented 10 months ago

It turns out "mirror on" is present in all the existing test cases, but mirror off is very common in senders in internal data pumps. so serious gap in test case coverage. fixed with this. current development branch fails this test but after a PR, it will pass.

andreleblanc11 commented 10 months ago

I think it looks good.

I'm just not sure what the calcres changes are for here https://github.com/MetPX/sr_insects/pull/27/commits/0831d16f38b96611d68b85eb0456c2da71a07a86#diff-cbfd6a4e72c76e23d434049bd20fd6b7a08bc36c107b992b48f320956d88a370

petersilva commented 10 months ago

That's a good question...

Instead of mirroring trees, as is done in the static_flow test, we are now mirroring just the data files. the options are changed so that we don't create empty directories in the destination, but we still need to publish the directory messages, in case someone downstream will choose mirror on, so the tree isn't "lost"

I'm not sure if that's the right idea or not. Anyways, the changes were made to the calcres because the number of files downloaded is no longer the same as the number of items posted, because the directories are skipped and then posted.

I'm actually puzzled as to whether we just just suppress the directories or not.

andreleblanc11 commented 10 months ago

Okay that makes sense. I'll merge the changes then.