search

MetPX / sr_insects

test cases for sarracenia python and c implementations.
GNU General Public License v2.0
0 stars 0 forks source link

the output of c implementation changed by sarrac issue 141 #38

Closed petersilva closed 5 months ago

petersilva commented 6 months ago

output of C implementation changes, implemented in: https://github.com/MetPX/sarrac/pull/144

to fix: https://github.com/MetPX/sarrac/issues/141

so both pulls should be merged at the same time (probably sr_insects first, then sarrac)

petersilva commented 6 months ago

Yeah that's missing... Good catch!

petersilva commented 6 months ago

second reading... no... line 371 is for guarded by an if statement that refers to older versions of sarrac, so it must not be modified. It is correct as is.

andreleblanc11 commented 6 months ago

That makes sense. Wouldn't that mean though that changes on restart_server/flow_include.sh at line 364 shouldn't be changed? Same thing for static_flow/flow_include.sh line 357?

petersilva commented 6 months ago

Since the C thing was merged, this needs to be merged... but when... it will break all the flow tests until the C patches are released...

petersilva commented 6 months ago

@andreleblanc11 yup... good catch. patch inbound.