Meta-Ben / Previewer_2D_3D

Godot Plugin : allow you to preview 2D and 3D during edition of the other
MIT License
17 stars 2 forks source link

preview is low resolution #1

Open leon196 opened 2 weeks ago

leon196 commented 2 weeks ago

Hello,

Thanks for the add-on, this is very useful. It appears that the preview is not at full resolution, this is a screenshot of project with Godot 4.3:

image

I'm looking at trying to fix it but I'm still learning how to use Godot and custom add-ons, so I'm wondering if you know how to resolve it?

Meta-Ben commented 2 weeks ago

Hello ! Just saw your comment, I will try to reproduce the problem !

Meta-Ben commented 2 weeks ago

@leon196 After some test I didn't succeed to reproduce your bug

I first tried with a big image as Sprite2D :

Capture d’écran 2024-09-24 à 14 30 20

Then I tried scaling this image to 1000 to see if your problem is caused by a too big image for the previewer but still I can see it fully and clearly :

Capture d’écran 2024-09-24 à 14 32 59

Maybe you can help me with some additional info :

Also when you say " the preview is not at full resolution" did you mean that your image in the preview is cropped ?

Those inputs could help me too fix your issue :)

leon196 commented 2 weeks ago

Thanks for the quick reply and taking the time to test.

Here's a video, it's hard to see quite right the actual resolution because of the compression: https://github.com/user-attachments/assets/70a1b3a8-7ec7-4e91-8edf-d4d512919c6b

Now that I've tried with a sprite2D, I think the plugin works as it should. It's how the minification of the texture works.

This is a screenshot of the default 2D view. image

And with the previewer. image

Since it's hard to tell, here the two close up of the views. image image

My goal is to pin the 2D view, to keep track of the comic layout, so I can update camera placement, while having a global view of the layout. I'll try to interact with the plugin source code a little more and keep you posted if I get something interesting.

Meta-Ben commented 2 weeks ago

Thanks for the huge input you gave me, It's really help me a lot to understand the problem you face ! I will take a look and try to fix this but it could take me some time, if the sprite2D method work go with it for now if you can

Meta-Ben commented 1 week ago

@leon196 I tried to setup my project the same as yours, but even in that I didn't succeed to reproduce your problem, here is my 2D preview quality using subview and control texture node :

Capture d’écran 2024-09-29 à 16 15 48

And here is the actual 2D control texture node quality in the 2D editor :

Capture d’écran 2024-09-29 à 16 16 26

Look like there is no difference for me, maybe try using the "nearest" option in your SubViewPortContainer ( the green one )

Capture d’écran 2024-09-29 à 16 19 02
leon196 commented 1 week ago

Interesting, thanks for exploring the issue. Setting nearest filter will change the rendering of the viewport container, but it still lacks of resolution. I'm playing with container size of the plugin scene, but I'm breaking everything very quickly. I'm not able to look at it further this week, but I'm keen to learn from your plugin to get that second 2D view screen.

Meta-Ben commented 1 week ago

I will continue to check when I can, though maybe not with pixel art images.

Don't hesitate to share your thoughts or progress on your investigation here or in a discussion topic on the repo. I will try to help you as best as I can.

If you succeed in fixing the problem on your own, don't hesitate to open a PR that I can review and merge for other users who might face the same issue. 😊