Closed gilest closed 8 years ago
Hi gilest, thanks for your pull request, and sorry for the late reply. It's really good to have support for the VJS 5.0 version! My concern is, however, VJS5.0 is still in it's early stage of life cycle, which means a lot of third party plugins haven't updated so far. So instead of merging your code into master, it would be actually better to have a separate branch dedicated for VJS 5.0 version until things getting more stable?
Hi featheast. I totally agree! Didn't really think before targeting master. I don't think it's possible to edit this PR to target a different branch. So should I close it and open another?
Hi gilest
Thanks also for your contribution. I checked your branch out and tried it myself - great stuff.
I have made a new branch called 'vjs5' which you can target. A couple of other suggestions if you are interested in updating the pull req:
VIDEOJS: WARN: The Shaka tech was registered as a component. It should instead be registered using videojs.registerTech(name, tech)
See new PR #6 for updated changes.
Hi there, thanks for putting this together.
Had a go at updating compatibility for the new release of Video.js.
A couple of notes:
grunt-contrib-connect
for use as a development server. It's in a separate commit so that I can yank it out if you please.References I used: