MetaCDN / videojs-vr_OLD

A video.js plugin that turns a video element into a HTML5 Panoramic 360 video player.
MIT License
24 stars 16 forks source link

HLS iOs hack working intermitently in Safari #10

Closed yarandoo closed 7 years ago

yarandoo commented 7 years ago

Thanks for the iOS hack #8. I could verify it is working though not all the times.

When using the video-js-vr plugin with our player(Brightcove). I am facing some issues where the isHLS() function, which is part of the logic to apply the IOS hack, is not correctly working. In desktop and mobile Safari.

I have identified the issue to be that some times at the moment of executing isHLS() - videoEl.src comes empty. Then the logic to match with the list of sources fails.

Any ideas why the videoEl.src can be empty on some ocassions? One out of ten times the src will be correctly populated and the hack applied correctly.

Can the isHLS logic be simplified to use player.currentType()?

Thanks!

<video data-account="92****001"
data-player="r**JIAhuaDg"
data-embed="default"
data-application-id
class="video-js"
controls
crossOrigin="anonymous"
playsinline
preload="auto"
webkit-playsinline
style="width: 100%; height: 100%; position: absolute; top: 0px; bottom: 0px; right: 0px; left: 0px;">
  <source src="https://secure.brightcove.com/services/mobile/streaming/index/master.m3u8?videoId=530***001&secure=true" type="application/x-mpegURL">
</video>
jbroberg commented 7 years ago

Thanks for the report - can you shoot me through a hosted example of your issue (either here or privately)?

yarandoo commented 7 years ago

Sent.

jbroberg commented 7 years ago

I just pushed a new release with your suggestion @yarandoo - can you let me know if it fixes your issue?

jbroberg commented 7 years ago

Closing - feel free to comment if you still have issues.