Closed filippomc closed 5 months ago
@zsinnema the version of this api is representative of the deployment so it's the same for all applications. It is indeed implemented only for the common app, what the samples app does here is to display the value in the ui.
@zsinnema the version of this api is representative of the deployment so it's the same for all applications. It is indeed implemented only for the common app, what the samples app does here is to display the value in the ui.
what I meant @filippomc is that we don't need an application to show the version number. We can just show it in the keycloak login screen.....
@zsinnema I think it can be a good idea to show the version in the keycloak login screen, but we are not customizing the keycloak theme on ch, which makes updates simpler. Also derived applications have their theme and might not want to show the version there.
Closes CH-47
Implemented solution: the build id (as git commit hash) is now extracted by harness-deployment and added to values.yaml. The common service exposes it and the tag. Added an example on samples microservice![image](https://github.com/MetaCell/cloud-harness/assets/46561561/d44558a0-65e5-4b3a-be3e-d9eac2b4e100)
How to test this PR: start samples.DOMAIN and verify that is shows the tag and build id as in the screenshot.
Sanity checks:
Breaking changes (select one):
breaking-change
Possible deployment updates issues (select one):
alert:deployment
Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):