condar-metacell commented 3 months ago

Implemented solution

A dockerfile section has been added under the haress section of an application which then has a buildArgs map which is provided to the dockerfile by Skaffold when building.

How to test this PR

Either run pytest to run the added unit test, or run harness-deployment -i samples and skaffold dev to see the value set in the values echoed out during build.

Sanity checks:

[x] The pull request is explicitly linked to the relevant issue(s)
[x] The issue is well described: clearly states the problem and the general proposed solution(s)
[x] In this PR it is explicitly stated how to test the current change
[x] The labels in the issue set the scope and the type of issue (bug, feature, etc.)
[ ] The relevant components are indicated in the issue (if any)
[ ] All the automated test checks are passing
[x] All the linked issues are included in one Sprint
[x] All the linked issues are in the Review state
[x] All the linked issues are assigned

Breaking changes (select one):

[x] The present changes do not change the preexisting api in any way
[ ] This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

[ ] There is no reason why deployments based on CloudHarness may break after the current update
[ ] This PR and the issue are tagged as alert:deployment

Test coverage (select one):

[ ] Tests for the relevant cases are included in this pr
[ ] The changes included in this pr are out of the current test coverage scope

Documentation (select one):

[ ] The documentation has been updated to match the current changes
[ ] The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

[ ] Screenshots of the changes
[ ] Explanatory video/animated gif

filippomc commented 3 months ago

@zsinnema this is useful for local development and debugging as mentioned in the Jira card, but I see your concern about this being abused as an attempt to set env variables on CI/CD and production systems. Let's be sure that the documentation states clearly that this feature shouldn't be used to set environment variables @condar-metacell

zsinnema commented 3 months ago

@filippomc @condar-metacell did you see my comment here: https://metacell.atlassian.net/browse/CH-142?focusedCommentId=15219?

MetaCell / cloud-harness

CH-142 Add dockerfile build args support to apps #763