MetaCell / geppetto-hnn

Geppetto extension for HNN
0 stars 0 forks source link

Order thumbnails manually #92

Closed rodriguez-facundo closed 5 years ago

rodriguez-facundo commented 5 years ago

Maybe the proper order for the thumbnails might come from metadata or maybe a client side function would be good enough. For now I just hard coded the order.

afonsobspinto commented 5 years ago

@rodriguez-facundo thanks for your PR. Firstly I agree that this logic is a workaround so I'm opening an issue for this. Secondly, this wasn't working for me, I think the problem was that you were assuming some specific order in the names array which (I don't know why) was not the same for me. I followed the same logic as you did but taking advantage of find and findIndex instead.

afonsobspinto commented 5 years ago

And I'm sneakily adding here also the ordering of the input parameters tabs which Salva also requested.