search

MetaCell / geppetto-meta

Other
4 stars 4 forks source link

Restore canvas threshold as before in order to display solid geometries #347

Open ddelpiano opened 2 years ago

ddelpiano commented 2 years ago

Reported by NetPyNE using the tutorial 2. We need to expose this parameter and make it configurable from the application

scrnli_24_03_2022_09-19-33 scrnli_24_03_2022_09-22-22

ddelpiano commented 2 years ago

value already part of the props as checked by Jasmine

ddelpiano commented 2 years ago

@Muhaddatha I tested the prop and it works but I noticed an issue, check the screenshot attached below:

netpyne pre migration to geppetto meta: scrnli_25_03_2022_11-36-22

netpyne using the latest geppetto meta: scrnli_25_03_2022_11-36-20

it seems that the linethreshold is applied only to the first instance in the network, could you please investigate into this? Thx

Muhaddatha commented 2 years ago

@ddelpiano I think the issue her is that the default Canvas linesThreshold is too low. I used lineThreshold={10000} as a prop for the Canvas in NetPyne. I tested on the development version of NetPyNE and the network went from: image.png

to this: image.png

Muhaddatha commented 2 years ago

Alternatively, we can increase the default threshold, but I'm not sure if that will affect performance (if related).