search

MetaCell / geppetto-scidash

Geppetto scidash extension
2 stars 1 forks source link

Feature/378 #410

Closed zsinnema closed 4 years ago

zsinnema commented 4 years ago

Filter values are not being reset when switching from test score view to suite view causing some confusion

378

Changes

Fix owner filter on score and suite pages Move owner, timestamp from and timestamp to filters to become global (for score & suite pages)

Related issues

378

zsinnema commented 4 years ago

I also noticed that not every filter is reset when accessing the system with URL parameters. @gidili in case of URL parameter do we want to reset all filters and take only the URL parameters? For example the default owner==user filter can then also be skipped. Or do we want the owner to be default set when user is logged in and accessing a page via a direct URL entry?

-- I've implemented it like this: when the user is logged in then when owner is omitted the default for the owner (the current user) will be added to the URL params. However when you add &owner= to the URL params then the filter will search "all"

jrmartin commented 4 years ago

@zsinnema That last commit did it, the timestamps in the UI are now the ones taken from the URL.