search

MetaCell / nwb-explorer

NWB Explorer is a web application to visualise and analyse the content of NWB:N 2 files
Other
23 stars 16 forks source link

Non-independent instances in browser tabs #131

Closed pgleeson closed 4 years ago

pgleeson commented 4 years ago

One intended behaviour of http://nwbexplorer.opensourcebrain.org/ is that each new instance of the site opened in a new browser tab should be independent, i.e. a unique instance related to a specific NWB file, allowing multiple files to be opened at the same time and compared (visually at least).

This does to seem to be the case and a new tab will default to the (long) URL of a previous tab causing a mix of files between the tabs (the new nwb file object can be accessed now at the python console of the old tab).

filippomc commented 4 years ago

@jrmartin console not working at http://35.226.194.155/

pgleeson commented 4 years ago

Seems to be a problem on the development deployment

pgleeson commented 4 years ago

I'm still seeing this issue in development when 2 tabs open http://35.226.194.155/. The same long url...

pgleeson commented 4 years ago

@filippomc It may be a fix that's been added in the k8a/GC setup for this. Do you want to do a merge to master and get all the recent fixes live so I can close the issues and tese any remaining ones on live?

filippomc commented 4 years ago

@pgleeson these are my tests:

  1. open http://35.226.194.155/nwbfile=https://github.com/OpenSourceBrain/NWBShowcase/raw/master/NWB/time_series_data.nwb
  2. open another tab on http://35.226.194.155, get the splash on the same pod (can se from the address, so same long url), open Ferguson.
  3. Go to the console in the 1st tab, time series data is loaded on nwbfile
  4. Go to the console in the 2nd tab, ferguson data is loaded on nwbfile

Second test

  1. open http://35.226.194.155/nwbfile=https://github.com/OpenSourceBrain/NWBShowcase/raw/master/NWB/time_series_data.nwb
  2. open on another tab http://35.226.194.155/nwbfile=https://github.com/OpenSourceBrain/NWBShowcase/raw/master/FergusonEtAl2015/FergusonEtAl2015.nwb, get another pod (different long url)
  3. Go to the console in the 1st tab, time series data is loaded on nwbfile
  4. Go to the console in the 2nd tab, ferguson data is loaded on nwbfile
pgleeson commented 4 years ago

Ok, looks good now. How about deploying this to live and more specific issues can be opened if required?