search

MetaCell / nwb-explorer

NWB Explorer is a web application to visualise and analyse the content of NWB:N 2 files
Other
23 stars 16 forks source link

Allow embedding from www.opensourcebrain.org #134

Closed filippomc closed 4 years ago

filippomc commented 4 years ago

When opening from here and clicking on the green eye we experience the following error: Refused to display 'http://nwbexplorer.opensourcebrain.org/hub/spawn-pending/ef3d2e0f-c180-4fba-9346-3fb972de1935/0568952078ae' in a frame because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'self' http://opensourcebrain.org:80 http://localhost:3000 http://comodl.org:80".

Probably we need to allow http://www.opensourcebrain.org:80 other than http://opensourcebrain.org:80?

pgleeson commented 4 years ago

The preferred target behaviour in the short term should probably be: user clicks on a green eye, a new tab is opened with the NWB explorer (not embedded in OSB for now...) and this is given the public URL of the selected NWB file, just as if a user had manually opened a tab & pasted the url.

These changes can probably happen all on the redmine side...

filippomc commented 4 years ago

@jrmartin I saw (and changed) the values in the deployment pipelines, so there is a possibility that there is nothing in the code to change

filippomc commented 4 years ago

@pgleeson I guess this would be a small change on the redmine side, anyway we'll need some time to get up to speed with redmine before making something with it. We may start looking at it at the next sprint in order to plan this and other changes you may want to make to that code base. @tarelli do you think?

tarelli commented 4 years ago

@filippomc @pgleeson it's doable, let's just allow enough time for developers to get familiar with the redmine codebase, probably not the top priority for now as I'd imagine we want first to have stable deployments for testing and production such that then we can easily work on changes like this.

pgleeson commented 4 years ago

I've updated this on live so it opens in a new tab for each click on a green eye: http://www.opensourcebrain.org/projects/nwbshowcase/repository/revisions/master/show/Lantyer

I'm not sure there's any need to have a short term solution which is embedded: what do you do if you want 2 nwb files open at the same time? Also, it just takes screenspace away from the main nwbexplorer UI. Closing for now until a more compelling use case comes up...