#189 Fix color selection

MetaCell / nwb-explorer

NWB Explorer is a web application to visualise and analyse the content of NWB:N 2 files

Other

23 stars 16 forks source link

#189 Fix color selection #198

Closed filippomc closed 4 years ago

filippomc commented 4 years ago

Closes #189

Now the color is used consistently in all plots of the same timeseries. The color is not even asked in case a timeseries is added, the default one is picked. Still not perfect since it would be more consistent to have a separate color picker but this will be fixed with the new interface under development.

Deployed on dev

pgleeson commented 4 years ago

Thanks @filippomc. Tried it out. Yes, a bit strange being able to pick the first colour and not the 2nd or 3rd (I only chose the yellow on the left plot below), but managable, and hopefully will be updated in the new interface.

Note though the showing of multiple plots is still broken, I asked to plot the 8 traces and got the empty panel on the right.

filippomc commented 4 years ago

@pgleeson thanks for spotting that. The multiple plot was wrongly filtering out subclasses of timeseries objects, so CurrentClampSeries were not considered. Now fixed.

pgleeson commented 4 years ago

Tested and it looks good. Happy for this to go live.